[sword-devel] Endless looping

[DM Smith]

This has been committed. To use, compile SWORD from SVN.

In Him,
	DM

> On Jun 16, 2025, at 5:07 PM, DM Smith <dmsmith at crosswire.org> wrote:
> 
> Pinoaffe, Michael,
> 
> Attached is a patch that will fix the endless looping bug.
> 
> The problem was in a verse in a chapter that was not in the chosen versification. Nitty gritty, incrementing a bad verse should have set an error. The fix for that was in src/keys/versekey.cpp in checkBounds.
> 
> That uncovered another problem in osis2mod that such verses were not properly placed at the end of the book in the last chapter.
> 
> Hope you can build this locally before we can check in this patch. I want Troy to review it, especially for unintended side effects.
> 
> In Him,
> 	DM
> 
> <osis2mod-infinite-loop.patch>
> 
>> On Apr 3, 2025, at 3:39 AM, pinoaffe <pinoaffe at gmail.com> wrote:
>> 
>> DM Smith <dmsmith at crosswire.org> writes:
>> 
>>> Can you supply a mock osis xml that reliably goes into an infinite loop? I’ve heard reports of this
>>> but cannot reproduce.
>> I've attached a file test.xml that goes into an infinite loop when I run
>> something like `osis2mod /tmp test.xml` on osis2mod version $Rev: 3769 $
>> (SWORD: 1.9.0)
>> 
>> I don't know for sure whether this is the issue that was reported, but
>> I've encountered this before: osis2mod seems to go into an infinite loop
>> when it encounters a chapter that is not in the versification.  This (or
>> similar infinite-looping issues with osis2mod) has been reported by
>> several others on this mailing list.
>> 
> <test.xml>
>> 
>> 
>> Kind regards,
>> pinoaffe
>> _______________________________________________
>> sword-devel mailing list: sword-devel at crosswire.org
>> http://crosswire.org/mailman/listinfo/sword-devel
>> Instructions to unsubscribe/change your settings at above page
>